[PATCH 2 of 2 STABLE] py3: use native strings when forming email headers in patchbomb

[Denis Laxalde]

Yuya Nishihara a écrit :
> On Fri, 25 Oct 2019 15:02:11 +0200, Denis Laxalde wrote:
> > # HG changeset patch
> > # User Denis Laxalde <denis at laxalde.org>
> > # Date 1572008488 -7200
> > #      Fri Oct 25 15:01:28 2019 +0200
> > # Branch stable
> > # Node ID 6058175493d062dbaec2cb0e897e49da4596d147
> > # Parent  17fad3f1b4742d75db23e17a04c85223bcc239a2
> > py3: use native strings when forming email headers in patchbomb
> 
> I feel this change is too big to be in stable.
> 
> > -        # Fix up all headers to be native strings.
> > -        # TODO(durin42): this should probably be cleaned up above in the future.
> > -        if pycompat.ispy3:
> > -            for hdr, val in list(m.items()):
> 
> Can't we somehow get around the issue here?

Well, I'm not sure I'd be interested in implementing a workaround,
especially here since the change aims at removing this TODO while making
the code Python 3 compatible. Fixing the issue is a side effect somehow.