[Bug 6212] New: monoblue: many help pages illegible due to layout problems

mercurial-bugs at mercurial-scm.org mercurial-bugs at mercurial-scm.org
Tue Oct 29 01:34:28 UTC 2019


https://bz.mercurial-scm.org/show_bug.cgi?id=6212

            Bug ID: 6212
           Summary: monoblue: many help pages illegible due to layout
                    problems
           Product: Mercurial
           Version: 5.2rc0
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Keywords: regression
          Severity: bug
          Priority: normal
         Component: hgweb
          Assignee: bugzilla at mercurial-scm.org
          Reporter: 4586274760 at munyer.com
                CC: mercurial-devel at mercurial-scm.org
    Python Version: 2.7

In the monoblue style, many help pages are illegible.  Paragraphs and most
other block-level elements are jammed together vertically with no
inter-paragraph spacing, and jammed against the left margin with no indenting.

I'm tagging this as a regression, because Mercurial 2.5.x didn't have this
problem.

Browse to https://www.mercurial-scm.org/repo/hg/help/config?style=monoblue and
scroll down, and you'll see illegible content.  That page also has hundreds of
validation errors caused by non-well-formed XML.

The underlying reason is a kind of layer violation: monoblue's CSS and DOCTYPE
were intended to apply only to XML elements that are marked up by monoblue
itself, not to elements that are marked up by minirst (which knows nothing
about monoblue) and then interpolated "behind monoblue's back" into monoblue's
markup.

I've been able to get legible, valid help pages by replacing

    <div id="doc">
    {rstdoc(doc, "html")}
    </div>

with

    <div id="doc">
        <pre>{escape(rstdoc(doc, "plain"))}</pre>
    </div>

in templates/monoblue/help.tmpl .

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list