D6822: flagprocessors: move _flagserrorclass attribute on revlog & co
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Sat Sep 7 09:30:42 UTC 2019
marmoute created this revision.
marmoute added reviewers: yuja, durin42.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a small duplication, and the last bit we need to get rid of the mixin.
Honestly, I am not fan of that class attribute and it mostly exist to accomodate
The simple-storage whose usage of flag processors is dumbious and that is
currently dead code anyway. However I don't want to be pulled into futher
unrelated cleaning so it is a small price to pay.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6822
AFFECTED FILES
hgext/remotefilelog/remotefilelog.py
mercurial/revlog.py
mercurial/revlogutils/flagutil.py
CHANGE DETAILS
diff --git a/mercurial/revlogutils/flagutil.py b/mercurial/revlogutils/flagutil.py
--- a/mercurial/revlogutils/flagutil.py
+++ b/mercurial/revlogutils/flagutil.py
@@ -87,8 +87,6 @@
See the documentation of the ``_processflags`` method for details.
"""
- _flagserrorclass = error.RevlogError
-
def processflagswrite(revlog, text, flags, sidedata):
"""Inspect revision data flags and applies write transformations defined
by registered flag processors.
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -298,6 +298,9 @@
If `upperboundcomp` is not None, this is the expected maximal gain from
compression for the data content.
"""
+
+ _flagserrorclass = error.RevlogError
+
def __init__(self, opener, indexfile, datafile=None, checkambig=False,
mmaplargeindex=False, censorable=False,
upperboundcomp=None):
diff --git a/hgext/remotefilelog/remotefilelog.py b/hgext/remotefilelog/remotefilelog.py
--- a/hgext/remotefilelog/remotefilelog.py
+++ b/hgext/remotefilelog/remotefilelog.py
@@ -51,6 +51,7 @@
class remotefilelog(flagutil.flagprocessorsmixin):
_generaldelta = True
+ _flagserrorclass = error.RevlogError
def __init__(self, opener, path, repo):
self.opener = opener
To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list