D6788: hgweb: fix websub regex flag syntax on Python 3

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Sep 7 12:50:20 EDT 2019


This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.


  Nice catch!

INLINE COMMENTS

> webutil.py:794
>          if flagin:
> -            for flag in flagin.upper():
> +            for flag in flagin.upper().decode('ascii'):
>                  flags |= re.__dict__[flag]

I think `pycompat.sysstr()` is more appropriate here, since it won't convert the `str` to `unicode` on Python 2.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6788/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6788

To: sheehan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list