D6814: revlog: add a `sidedata` parameters to addrevision

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sat Sep 7 13:12:55 EDT 2019


indygreg added inline comments.

INLINE COMMENTS

> remotefilelog.py:133
>      def addrevision(self, text, transaction, linknode, p1, p2, cachedelta=None,
> -                    node=None, flags=revlog.REVIDX_DEFAULT_FLAGS):
> +                    node=None, flags=revlog.REVIDX_DEFAULT_FLAGS, sidedata=()):
>          # text passed to "addrevision" includes hg filelog metadata header

Why an empty tuple here? Isn't `None` more Pythonic?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6814/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6814

To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list