D6814: revlog: add a `sidedata` parameters to addrevision
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Mon Sep 9 13:52:24 EDT 2019
This revision now requires changes to proceed.
durin42 added inline comments.
durin42 requested changes to this revision.
> marmoute wrote in remotefilelog.py:133
> because it can be iterated over as a noop.
I agree with Greg: if your intent is "optional iterable of data", the tuple is misguided and will cause problems for typecheckers. I know it adds two lines, but None is the correct way to spell "optional value that was empty" in this case.
CHANGES SINCE LAST ACTION
To: marmoute, yuja, durin42, indygreg, #hg-reviewers
More information about the Mercurial-devel