D6814: revlog: add a `sidedata` parameters to addrevision

[durin42 (Augie Fackler)]

This revision now requires changes to proceed.
durin42 added inline comments.
durin42 requested changes to this revision.

INLINE COMMENTS

> marmoute wrote in remotefilelog.py:133
> because it can be iterated over as a noop.

I agree with Greg: if your intent is "optional iterable of data", the tuple is misguided and will cause problems for typecheckers. I know it adds two lines, but None is the correct way to spell "optional value that was empty" in this case.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6814/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6814

To: marmoute, yuja, durin42, indygreg, #hg-reviewers
Cc: mercurial-devel