[PATCH 5 of 5] changegroup: move message about added changes to transaction summary

[Martin von Zweigbergk]

On Mon, Sep 9, 2019 at 10:27 PM Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

> On 9/10/19 6:01 AM, Martin von Zweigbergk wrote:
> >
> >
> > On Sun, Sep 8, 2019 at 1:09 AM Pierre-Yves David
> > <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
>
> > wrote:
> >
> >     # HG changeset patch
> >     # User Pierre-Yves David <pierre-yves.david at octobus.net
> >     <mailto:pierre-yves.david at octobus.net>>
> >     # Date 1567928573 -7200
> >     #      Sun Sep 08 09:42:53 2019 +0200
> >     # Node ID 275367f9cadd11d65128051d920414f4b76f5de6
> >     # Parent  426a83641e1b9a94775bd2c3db0033d141432608
> >     # EXP-Topic check-summary
> >     # Available At https://bitbucket.org/octobus/mercurial-devel/
> >     #              hg pull
> >     https://bitbucket.org/octobus/mercurial-devel/ -r 275367f9cadd
> >     changegroup: move message about added changes to transaction summary
> >
> >     diff --git a/tests/test-bookflow.t b/tests/test-bookflow.t
> >     --- a/tests/test-bookflow.t
> >     +++ b/tests/test-bookflow.t
> >     @@ -242,8 +242,8 @@ make the bookmark move by updating it on
> >         $ echo "more" >> test
> >         $ hg pull -u 2>&1 | fgrep -v TESTTMP| fgrep -v "searching for
> >     changes" | fgrep -v adding
> >         pulling from $TESTTMP/a
> >     +  updating bookmark X
> >         added 1 changesets with 0 changes to 0 files (+1 heads)
> >     -  updating bookmark X
> >
> >
> > This is now slightly weird in that it seems like the bookmark is updated
> > before the changesets are added...
>
> This is actually correct since the bookmark are updating while the
> transaction is going while the changesets are added once the transaction
> is completed ;-)
>

Sure, I know why it's happening; I just mean that it may seem weird to
regular users (although I also think that very few actually read these
messages).


> --
> Pierre-Yves David
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190909/beeca4f9/attachment.html>