D6659: graft: split graft code into seperate functions

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Sep 11 15:27:16 UTC 2019


This revision now requires changes to proceed.
durin42 added inline comments.
durin42 requested changes to this revision.

INLINE COMMENTS

> cmdutil.py:3497
> +
> +def updateopts(repo, graftstate, opts):
> +    """updates opts and nodes from graftstate in case graft

This function is still mutating the opts parameter. You could fix that by doing opts=dict(opts) on the first line if you want, or otherwise making a copy.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6659/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6659

To: taapas1128, #hg-reviewers, durin42
Cc: pulkit, durin42, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list