D6773: rust-hgpath: add HgPath and HgPathBuf structs to encapsulate handling of paths

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Fri Sep 13 06:49:10 EDT 2019


kevincox added inline comments.
kevincox accepted this revision.

INLINE COMMENTS

> hg_path.rs:175
> +    pub fn push(&mut self, byte: u8) {
> +        self.inner.push(byte);
> +    }

debug_assert check after the mutation.

> hg_path.rs:242
> +    fn extend<T: IntoIterator<Item = u8>>(&mut self, iter: T) {
> +        self.inner.extend(iter);
> +    }

debug_assert check after the mutation.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6773/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6773

To: Alphare, #hg-reviewers, kevincox
Cc: mjpieters, yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list