D6776: bookmarks: validate changes on push (issue6193) (BC)
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Fri Sep 13 09:40:55 EDT 2019
durin42 added a comment.
In D6776#100487 <https://phab.mercurial-scm.org/D6776#100487>, @valentin.gatienbaron wrote:
> I showed in D6847 <https://phab.mercurial-scm.org/D6847> the same change but implemented in exchange._processcompared. Tests pass.
> I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.
Isn't that a client-side change only though, so we still need functionality on the server to reject bad pushes? (I could be missing something.)
CHANGES SINCE LAST ACTION
To: idlsoft, #hg-reviewers, durin42
Cc: pulkit, durin42, valentin.gatienbaron, mercurial-devel
More information about the Mercurial-devel