D6848: narrow: add option for automatically removing unused includes
rdamazio (Rodrigo Damazio Bovendorp)
phabricator at mercurial-scm.org
Fri Sep 13 20:40:55 EDT 2019
rdamazio added inline comments.
> martinvonz wrote in test-narrow.t:457
> > This obsolete commit is completely lost afterwards, which kind of violates the principle of "all changes are kept forever" - should it dump this somewhere for safekeeping?
> Yes, it does dump it to a backup bundle (see output on line 474).
> > Also, what if you just don't get rid of the files, and simply remove it from the narrowspec? It'll stop processing/pulling/pushing the directory, but no data is lost.
> That's just about the working directory, right? This file is unchanged in the working directory at the time of `hg tracked --auto-remove-includes`...
> That's just about the working directory, right? This file is unchanged in the working directory at the time of hg tracked --auto-remove-includes...
No, I meant what if you don't get rid of the .i files.
But you raise a good point - shouldn't you also clean up the working directory?
Alternatively, or in addition, maybe a confirmation prompt pointing out which commits and narrowspec entries will be dropped may be useful.
CHANGES SINCE LAST ACTION
To: martinvonz, durin42, #hg-reviewers
Cc: rdamazio, mercurial-devel
More information about the Mercurial-devel