D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC)

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Sep 23 15:34:27 EDT 2019


durin42 added a comment.


  I asked some coworkers, and they said:
  
  > I do not believe this to be correct. An object is Sync if it is *inherently* thread-safe. This object is not -- the first thing borrow_mut does is a racy read of mutably_borrowed.
  
  so I'm now leaning towards this being a bad idea.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6859/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6859

To: yuja, #hg-reviewers
Cc: Alphare, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list