D6880: rebase: track new nodes when --keep is set

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Sep 26 19:20:54 EDT 2019


martinvonz added inline comments.

INLINE COMMENTS

> rebase.py:1808-1810
> +    if keepf:
> +        replacements = {}
> +    scmutil.cleanupnodes(repo, replacements, 'rebase', moves, backup=backup)

It looks like this still moves bookmarks, right (in the `moves` dict)? Should `scmutil.cleanupnodes()` simply only be called if `not keepf`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6880/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6880

To: pgossman, martinvonz, #hg-reviewers, pulkit
Cc: mercurial-devel


More information about the Mercurial-devel mailing list