D6880: rebase: track new nodes when --keep is set

Thu Sep 26 20:16:17 EDT 2019

martinvonz added inline comments.

INLINE COMMENTS

> pgossman wrote in rebase.py:1808-1810
> Yes this moves them. With --keep, bookmarks should still be moved.
> 
> See rebase help or https://bz.mercurial-scm.org/show_bug.cgi?id=5682

Oh, right, that bug... I agree that it's good that this patch preserves that behavior to avoid doing multiple things in one patch. But I think the current behavior is pretty surprising. I'm curious what you think since you apparently use `hg rebase --keep` (I don't).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6880/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6880

To: pgossman, martinvonz, #hg-reviewers, pulkit
Cc: mercurial-devel