[PATCH V2] patchbomb: protect email addresses from shell

[Yuya Nishihara]

On Mon, 30 Sep 2019 21:22:17 +0200, Floris Bruynooghe wrote:
> # HG changeset patch
> # User Floris Bruynooghe <flub at google.com>
> # Date 1569794518 -7200
> #      Mon Sep 30 00:01:58 2019 +0200
> # Node ID 7c69ab0787ac4931a5d4568704eb88e86d9c6b83
> # Parent  bbf77341a956b3ba40ae87538fcd200b34c5a3e5
> patchbomb: protect email addresses from shell

> diff --git a/mercurial/mail.py b/mercurial/mail.py
> --- a/mercurial/mail.py
> +++ b/mercurial/mail.py
> @@ -152,7 +152,8 @@ def _smtp(ui):
>  def _sendmail(ui, sender, recipients, msg):
>      '''send mail using sendmail.'''
>      program = ui.config('email', 'method')
> -    stremail = lambda x: stringutil.email(encoding.strtolocal(x))
> +    stremail = lambda x: \
> +        procutil.quote(stringutil.email(encoding.strtolocal(x)))

procutil.shellquote() ?

I don't think shlex supports byte strings on Python 3, and maybe it wouldn't
respect the cmd.exe rule on Windows.