D7543: revlog: made C Capsule an array of function pointers

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Sat Jan 4 05:42:08 EST 2020


gracinet added a comment.


  @yuja for now I'm indeed implicitely assuming both were built from the same source tree, but I understand your concern.
  A possibility, since we're now on this data + functions capsule would be to introduce an ABI version number in the capsule.
  At least, that's the first thing that comes to mind.
  
  If that check were in `Index::new()`, I'm confident it wouldn't have any performance impact.
  What kind of error feedback could we be sending, then ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7543/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7543

To: gracinet, #hg-reviewers, indygreg
Cc: yuja, indygreg, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list