D7543: revlog: made C Capsule an array of function pointers

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Jan 4 08:04:44 EST 2020


yuja added a comment.


  >   A possibility, since we're now on this data + functions capsule would be to introduce an ABI version number in the capsule.
  >   At least, that's the first thing that comes to mind.
  
  Yeah, parsers.c:version could be embedded, for example.
  
  >   If that check were in `Index::new()`, I'm confident it wouldn't have any performance impact.
  >   What kind of error feedback could we be sending, then ?
  
  I think any Python-level exception should be fine. My only concern is somehow
  incompatible C+Rust extensions happen to work (e.g. memory layout was similar),
  but causes data loss. Import-time error might be better if that can be easily
  implemented.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7543/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7543

To: gracinet, #hg-reviewers, indygreg
Cc: yuja, indygreg, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list