D7785: remotefilelog: actually fix (and test this time) a bytes vs str issue

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Jan 8 06:59:41 EST 2020


pulkit added inline comments.

INLINE COMMENTS

> test-remotefilelog-prefetch.t:253
> +  >             repo.fileservice.prefetch([(b'somefile.txt', hexid)])
> +  >         except:
> +  >             pass

`test-check-code.t` fails now:

  --- /home/pulkitg/repo/hgpush/tests/test-check-code.t
  +++ /home/pulkitg/repo/hgpush/tests/test-check-code.t.err
  @@ -32,6 +32,10 @@
     Skipping i18n/polib.py it has no-che?k-code (glob)
     Skipping mercurial/statprof.py it has no-che?k-code (glob)
     Skipping tests/badserverext.py it has no-che?k-code (glob)
  +  tests/test-remotefilelog-prefetch.t:253:
  +   >         except:
  +   naked except clause
  +  [1]
   
   @commands in debugcommands.py should be in alphabetical order.
   
  
  ERROR: test-check-code.t output changed

Can you send a followup?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7785/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7785

To: spectral, #hg-reviewers
Cc: pulkit, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list