D7815: sha1dc: initial implementation of Python extension (NOT READY)

[durin42 (Augie Fackler)]

durin42 added inline comments.
durin42 marked 4 inline comments as done.

INLINE COMMENTS

> spectral wrote in cext.c:24
> Nit: "clang-format on" (typo: s/oon/on/)

Good catch!

> spectral wrote in cext.c:104
> I think you need a {NULL} entry here, or else it's going to walk off the end of this array when creating the type.

Sigh, yep.

> spectral wrote in cext.c:152
> why do this here instead of above?

Not sure. This is just how I've always seen it done...

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7815/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7815

To: durin42, #hg-reviewers
Cc: spectral, mjpieters, mercurial-devel