D7874: phabricator: post revisions in ascending topological order (issue6241)

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Tue Jan 14 21:39:58 UTC 2020


mharbison72 created this revision.
Herald added subscribers: mercurial-devel, Kwan.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The parent in phabricator ends up being the last revision posted, so sorting the
  user input into ascending order should be enough to preserve the proper
  relationships.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7874

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -1065,6 +1065,7 @@
     opts = pycompat.byteskwargs(opts)
     revs = list(revs) + opts.get(b'rev', [])
     revs = scmutil.revrange(repo, revs)
+    revs.sort()  # ascending order to preserve topological parent/child in phab
 
     if not revs:
         raise error.Abort(_(b'phabsend requires at least one changeset'))



To: mharbison72, #hg-reviewers
Cc: Kwan, mercurial-devel


More information about the Mercurial-devel mailing list