D7880: lfs: rename a variable to clarify its use

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Tue Jan 14 23:09:38 EST 2020


mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This is the response object, not a request.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7880

AFFECTED FILES
  hgext/lfs/blobstore.py

CHANGE DETAILS

diff --git a/hgext/lfs/blobstore.py b/hgext/lfs/blobstore.py
--- a/hgext/lfs/blobstore.py
+++ b/hgext/lfs/blobstore.py
@@ -491,22 +491,22 @@
 
         response = b''
         try:
-            with contextlib.closing(self.urlopener.open(request)) as req:
+            with contextlib.closing(self.urlopener.open(request)) as res:
                 ui = self.ui  # Shorten debug lines
                 if self.ui.debugflag:
-                    ui.debug(b'Status: %d\n' % req.status)
+                    ui.debug(b'Status: %d\n' % res.status)
                     # lfs-test-server and hg serve return headers in different
                     # order
-                    headers = pycompat.bytestr(req.info()).strip()
+                    headers = pycompat.bytestr(res.info()).strip()
                     ui.debug(b'%s\n' % b'\n'.join(sorted(headers.splitlines())))
 
                 if action == b'download':
                     # If downloading blobs, store downloaded data to local
                     # blobstore
-                    localstore.download(oid, req)
+                    localstore.download(oid, res)
                 else:
                     while True:
-                        data = req.read(1048576)
+                        data = res.read(1048576)
                         if not data:
                             break
                         response += data



To: mharbison72, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list