D7787: rust-nodemap: building blocks for nodetree structures

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Wed Jan 15 09:02:26 EST 2020


kevincox added inline comments.
kevincox accepted this revision.

INLINE COMMENTS

> nodemap.rs:92
> +
> +    fn read(&self, nybble: u8) -> Element {
> +        Element::from(RawElement::from_be(self.0[nybble as usize]))

I would call these `get` and `set`.

> nodemap.rs:111
> +        }
> +        write!(f, "[{}]", inner.join(", "))
> +    }

You can use this helper: https://doc.rust-lang.org/std/fmt/struct.Formatter.html#method.debug_map

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7787/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7787

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list