D7787: rust-nodemap: building blocks for nodetree structures

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Wed Jan 15 18:56:02 EST 2020


gracinet added inline comments.
gracinet marked 2 inline comments as done.

INLINE COMMENTS

> gracinet wrote in nodemap.rs:111
> Nice, thanks for the tip

So, that gives formatting with braces, hence for consistency I changed the `block!` macro, too.

I didn't keep the hexadecimal formatting, because it'd now lead to lots of `\"` making the tests less readable.

An upside of this is that it's now really consistent with `block!`. A downside is that someone using it for real debugging with input given in hexadecimal would presumably have to mentally convert hexadecimal nybbles to their decimal form.
It would have been a bit of a drag in the intiial development effort, but I don't think
that'll be a problem in the future: : either it'll be on small data or with diffrent tools anyway.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7787/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7787

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list