D7829: rebase: remove some now-unused parent arguments
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jan 16 03:19:04 EST 2020
martinvonz updated this revision to Diff 19347.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7829?vs=19149&id=19347
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7829/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7829
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -505,7 +505,7 @@
p.complete()
ui.note(_(b'rebase merging completed\n'))
- def _concludenode(self, rev, p1, p2, editor, commitmsg=None):
+ def _concludenode(self, rev, p1, editor, commitmsg=None):
'''Commit the wd changes with parents p1 and p2.
Reuse commit info from rev but also store useful information in extra.
@@ -529,8 +529,6 @@
if self.inmemory:
newnode = commitmemorynode(
repo,
- p1,
- p2,
wctx=self.wctx,
extra=extra,
commitmsg=commitmsg,
@@ -542,8 +540,6 @@
else:
newnode = commitnode(
repo,
- p1,
- p2,
extra=extra,
commitmsg=commitmsg,
editor=editor,
@@ -639,7 +635,7 @@
editor = cmdutil.getcommiteditor(
editform=editform, **pycompat.strkwargs(opts)
)
- newnode = self._concludenode(rev, p1, p2, editor)
+ newnode = self._concludenode(rev, p1, editor)
else:
# Skip commit if we are collapsing
newnode = None
@@ -698,7 +694,7 @@
self.wctx.setparents(repo[p1].node(), repo[self.external].node())
newnode = self._concludenode(
- revtoreuse, p1, self.external, editor, commitmsg=commitmsg
+ revtoreuse, p1, editor, commitmsg=commitmsg
)
if newnode is not None:
@@ -1419,7 +1415,7 @@
)
-def commitmemorynode(repo, p1, p2, wctx, editor, extra, user, date, commitmsg):
+def commitmemorynode(repo, wctx, editor, extra, user, date, commitmsg):
'''Commit the memory changes with parents p1 and p2.
Return node of committed revision.'''
# Replicates the empty check in ``repo.commit``.
@@ -1445,7 +1441,7 @@
return commitres
-def commitnode(repo, p1, p2, editor, extra, user, date, commitmsg):
+def commitnode(repo, editor, extra, user, date, commitmsg):
'''Commit the wd changes with parents p1 and p2.
Return node of committed revision.'''
dsguard = util.nullcontextmanager()
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list