D7819: rust-nodemap: core implementation for shortest

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Thu Jan 16 07:24:58 EST 2020


kevincox added inline comments.
kevincox accepted this revision.

INLINE COMMENTS

> nodemap.rs:337
>      /// Main working method for `NodeTree` searches
>      fn lookup<'p>(
>          &self,

Can you describe the return value in the doc comment.

> nodemap.rs:575
> +
> +    fn shortest_bin<'a>(
> +        &self,

How about `unique_bin_prefix_len`?

> nodemap.rs:766
>  
> +        fn shortest_hex(
> +            &self,

`unique_bin_prefix_len`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7819/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7819

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list