D7869: rust-dirs-multiset: add `DirsChildrenMultiset`
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Thu Jan 16 07:46:54 EST 2020
kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> hg_path.rs:197
> + /// ```
> + pub fn split_at_suffix(&self) -> (&Self, &Self) {
> + match &self.inner.iter().rposition(|c| *c == b'/') {
"suffix" isn't clear to me. Maybe `split_dir_from_file`? That's a bit wordy but I feel that it gets the point across. Or `split_file_name`.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7869/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7869
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list