D7910: rust-re2: add wrapper for calling Re2 from Rust
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Thu Jan 16 10:42:20 EST 2020
This revision now requires changes to proceed.
kevincox added inline comments.
kevincox requested changes to this revision.
INLINE COMMENTS
> rust_re2.cpp:22
> +
> + return new RE2(StringPiece(data, len), o);
> + }
This is never freed. Should we add a `Drop` implementation in rust?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7910/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7910
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list