D7910: rust-re2: add wrapper for calling Re2 from Rust

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Jan 16 10:43:55 EST 2020


durin42 added a comment.


  In D7910#116208 <https://phab.mercurial-scm.org/D7910#116208>, @kevincox wrote:
  
  > Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate?
  
  We have support for using re2 iff the correct Python bindings are installed. That said, I thought the rust regex crate would be compatible with re2? If we can't use that, we should document why so that future hackers (like me) don't try and simplify....

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7910/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7910

To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list