D7833: transaction: allow finalizer to add finalizer

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Jan 16 11:49:19 EST 2020


martinvonz added inline comments.

INLINE COMMENTS

> transaction.py:511
> +                callbacks = self._finalizecallback
> +                self._finalizecallback = {}
> +                categories = sorted(callbacks)

Any reason to not set this to `None` as we do on line 516? Also, can we remove that line now?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7833/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7833

To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list