D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Jan 16 13:21:27 EST 2020


Alphare added inline comments.
Alphare marked 2 inline comments as done.

INLINE COMMENTS

> kevincox wrote in filepatterns.rs:462
> I would write this as `Some(Ok(match syntax { .. }))` as the last expression of this map. Then instead of `res.extend()` and `res.push()` you just return the vecs.

The `match` arms would be incompatible. Or maybe I'm missing something.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7909/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7909

To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list