D7867: rust-hg-path: add useful methods to `HgPath`
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Thu Jan 16 13:22:24 EST 2020
Alphare added inline comments.
> kevincox wrote in hg_path.rs:169
> I don't think we should have this method. It provides us no way to ensure that the invariants of this type are upheld. It is slightly more typing but I think we should recommend converting to a slice, doing the mutation, then converting back to `HgPath` then we can at least to validation (possibly only in debug builds) in the constructor.
CHANGES SINCE LAST ACTION
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel