D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Thu Jan 16 14:40:44 EST 2020


kevincox added inline comments.

INLINE COMMENTS

> Alphare wrote in filepatterns.rs:462
> The `match` arms would be incompatible. Or maybe I'm missing something.

You would have to make sure you return a Vec on both arms. You will probably want `inner_pats.into_iter().collect()` on one branch and `vec![entry]` on the other branch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7909/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7909

To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list