D7908: rust-filepatterns: improve API and robustness for pattern files parsing
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Thu Jan 16 15:35:19 EST 2020
kevincox added inline comments.
> Alphare wrote in filepatterns.rs:237
> I might be using godbolt wrong but it looks like you are using different versions of rustc. When using 1.40 for both sides, I don't see any clear win on either side... but I'm not fluent in assembly either. As I'm sure you'll agree, this function is unlikely to show up in future profiles anyway.
Oops. My mistake. But I think we agree that readability is the top priority (until profiles say otherwise)
CHANGES SINCE LAST ACTION
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel