D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Jan 17 01:35:29 EST 2020


martinvonz added inline comments.

INLINE COMMENTS

> matchers.rs:166
>      }
>      fn visit_children_set(
>          &self,

This will often be called repeatedly, so isn't it better to calculate a map of each parent directory to its `VisitChildrenSet` value upfront (in `FilesMatcher::new()`)?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7914/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7914

To: Alphare, #hg-reviewers
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list