D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Jan 17 11:08:07 EST 2020


martinvonz added inline comments.

INLINE COMMENTS

> Alphare wrote in matchers.rs:166
> Agreed. In much of this series there exist opportunities for caching/making things run in parallel, etc. With the freeze approaching really fast, I prefer to prioritize getting correct - albeit sub-optimal - code in rather than risking missing the deadline. 
> My benchmarks of the entire series show an improvement in bare `hg status`  in all supported repositories (read: that don't have back-references in their `.hgignore patterns), and no measurable slowdown in others.

Yes, code quality is never urgent. The problem is that there isn't much incentive for people to clean it up after. So I'd really prefer to not queue this without the cleanup.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7914/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7914

To: Alphare, #hg-reviewers
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list