D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Fri Jan 17 11:51:55 EST 2020
Alphare added inline comments.
> martinvonz wrote in matchers.rs:166
> Yes, code quality is never urgent. The problem is that there isn't much incentive for people to clean it up after. So I'd really prefer to not queue this without the cleanup.
I don't feel like this is an issue of code quality. This is (probably) an issue of performance, and I have a good incentive for making this code go faster in the future. I don't think this is necessary for now since this is a minor optimization compared to the other ones that are pending.
CHANGES SINCE LAST ACTION
To: Alphare, #hg-reviewers
Cc: martinvonz, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel