D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Jan 17 12:30:34 EST 2020
martinvonz added inline comments.
> Alphare wrote in matchers.rs:166
> I don't feel like this is an issue of code quality. This is (probably) an issue of performance, and I have a good incentive for making this code go faster in the future. I don't think this is necessary for now since this is a minor optimization compared to the other ones that are pending.
How about we just replace the implementation by `VisitChildrenSet::Recursive`then? That's easy to maintain and makes it functionally correct. It's usually fast enough too.
CHANGES SINCE LAST ACTION
To: Alphare, #hg-reviewers
Cc: martinvonz, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel