D7819: rust-nodemap: core implementation for shortest

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Jan 22 13:39:24 EST 2020


martinvonz added inline comments.

INLINE COMMENTS

> gracinet wrote in nodemap.rs:575
> I have personally nothing against this, and actually find this `shortest` not to be clear, but… it's also the name in the C implementation and the Python API, IIRC.
> 
> @martinvonz I see you subscribed, what do you think ?

I'm fine with either. We'll expose it as "shortest" in the python API anyway, I assume. Feel free to change as far as I'm concerned.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7819/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7819

To: gracinet, #hg-reviewers, kevincox
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list