D7517: filemerge: byteify the open() mode
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Thu Jan 23 12:30:44 EST 2020
mharbison72 added a comment.
In D7517#117274 <https://phab.mercurial-scm.org/D7517#117274>, @marmoute wrote:
> This have been around for a while. What should we do with it?
Since it's not a bug fix, I guess I can abandon it. I left it open as a reminder that there are inconsistencies with with how strings are passed to builtins, and am wondering if there's any interest in using str instead of bytes for things like this since it seems to occasionally confuse static analyzers. (Yes, I know this change goes the opposite way.)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7517/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7517
To: mharbison72, #hg-reviewers
Cc: marmoute, durin42, dlax, mercurial-devel
More information about the Mercurial-devel
mailing list