D7835: nodemap: write nodemap data on disk
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jan 23 13:51:27 EST 2020
martinvonz added inline comments.
INLINE COMMENTS
> nodemap.py:42
> + raise error.ProgrammingError(
> + "cannot persist nodemap of a filtered changelog"
> + )
need b'' here and below for py3?
> nodemap.py:49
> + # EXP-TODO: if this is a cache, this should use a cache vfs, not a
> + # store vfs
> + with revlog.opener(revlog.nodemap_file, 'w') as f:
and here? this is a series that introduced a lot of new code, so try running all (previously passing) py3 test at least at the end of the series
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7835/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7835
To: marmoute, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list