D7867: rust-hg-path: add useful methods to `HgPath`

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Jan 24 04:49:46 EST 2020


Alphare added inline comments.

INLINE COMMENTS

> martinvonz wrote in hg_path.rs:173
> When do we create such paths? I can imagine using them for referring to directories. Is that it? If it's some other use-case, I wonder if we can instead prevent the trailing slash from entering the `HgPath`.

Maybe, but I'm not sure it's worth risking a weird edge-case bug or losing performance over (possibly negligible). What do you think?

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7867/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7867

To: Alphare, #hg-reviewers, kevincox, pulkit
Cc: martinvonz, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list