D7921: rust-dirs-multiset: improve temporary error message
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Fri Jan 24 04:59:25 EST 2020
This revision now requires changes to proceed.
kevincox added inline comments.
kevincox requested changes to this revision.
INLINE COMMENTS
> dirs_multiset.rs:86
> + subpath.as_bytes(),
> + );
> + let second_slash_index = offset.unwrap() + subpath.len() - 1;
It appears to me that `find_dirs` always returns prefixes. Why is this offset required?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7921/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7921
To: Alphare, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list