D7906: rebase: define base in only place in defineparents()
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Mon Jan 27 09:40:47 EST 2020
pulkit added inline comments.
INLINE COMMENTS
> rebase.py:1811
> + newps[0], newps[i] = newps[i], newps[0]
> + bases[0], bases[i] = bases[i], bases[0]
> +
I am not sure why we are doing `bases[i] = bases[0]` here? (TBH I didn't try to understand the whole logic, mostly only the diff)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7906/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7906
To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list