D7906: rebase: define base in only place in defineparents()

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in rebase.py:1811
> I am not sure why we are doing `bases[i] = bases[0]` here? (TBH I didn't try to understand the whole logic, mostly only the diff)

Doing it only for consistency with `newps`. `bases` and `newps` should be kept in sync (we don't do that in one other place, but that's pretty weird, IMO). So I think it's clearer this way even though it's unnecessary.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7906/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7906

To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel