D7906: rebase: define base in only place in defineparents()
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Mon Jan 27 09:44:01 EST 2020
martinvonz added inline comments.
> pulkit wrote in rebase.py:1811
> I am not sure why we are doing `bases[i] = bases` here? (TBH I didn't try to understand the whole logic, mostly only the diff)
Doing it only for consistency with `newps`. `bases` and `newps` should be kept in sync (we don't do that in one other place, but that's pretty weird, IMO). So I think it's clearer this way even though it's unnecessary.
CHANGES SINCE LAST ACTION
To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel