D7792: rust-nodemap: abstracting the indexing
gracinet (Georges Racinet)
phabricator at mercurial-scm.org
Mon Jan 27 10:53:44 EST 2020
gracinet added inline comments.
gracinet marked 2 inline comments as done.
INLINE COMMENTS
> kevincox wrote in nodemap.rs:193
> I would add a `self.is_empty()` helper. It's good practice for anything that has a `.len()`.
Sure
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7792/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7792
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list