D7819: rust-nodemap: core implementation for shortest
gracinet (Georges Racinet)
phabricator at mercurial-scm.org
Mon Jan 27 11:08:10 EST 2020
gracinet added inline comments.
gracinet marked 3 inline comments as done.
INLINE COMMENTS
> kevincox wrote in nodemap.rs:337
> Can you describe the return value in the doc comment.
Done
> martinvonz wrote in nodemap.rs:575
> I'm fine with either. We'll expose it as "shortest" in the python API anyway, I assume. Feel free to change as far as I'm concerned.
Okay, I've settled with `unique_prefix_len_bin` etc, keeping the convention that it's `something_bin`, `something_hex`, etc.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7819/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7819
To: gracinet, #hg-reviewers, kevincox
Cc: martinvonz, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list