D7794: rust-nodemap: generic NodeTreeVisitor
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Mon Jan 27 14:00:59 EST 2020
martinvonz added inline comments.
martinvonz accepted this revision.
INLINE COMMENTS
> nodemap.rs:300
> + prefix: NodePrefixRef<'p>,
> + visit: usize,
> + nybble_idx: usize,
would something like `block_index` be clearer?
> nodemap.rs:312
> +
> +impl<'n, 'p> Iterator for NodeTreeVisitor<'n, 'p> {
> + type Item = NodeTreeVisitItem;
can these lifetimes be anonymous?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7794/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7794
To: gracinet, #hg-reviewers, kevincox, martinvonz
Cc: martinvonz, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list