D7790: rust-node: handling binary Node prefix
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Mon Jan 27 14:09:58 EST 2020
martinvonz added inline comments.
> gracinet wrote in node.rs:226
> yes, indeed.
> current callers from `nodemap` work either on full Nodes or (the visitor) by explicitely bounding with `prefix.len()`, but it's safer to protect it inconditonally.
> I think a simple `assert!` is enough though: that's already what slicing does anyway.
Yes, an `assert!` is probably what I had in mind. I've already queued this, so please send in a follow-up.
CHANGES SINCE LAST ACTION
To: gracinet, #hg-reviewers, martinvonz
Cc: martinvonz, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel