D8021: chg: switch to using global `environ` instead of envp from main

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Jan 28 11:10:52 EST 2020


yuja added a comment.


  > {
  >
  >   	if (getenv("CHGDEBUG"))
  >   		enabledebugmsg();
  >
  > @@ -429,7 +431,7 @@
  >
  >   		hgc = connectcmdserver(&opts);
  >   		if (!hgc)
  >   			abortmsg("cannot open hg client");
  >
  > - hgc_setenv(hgc, envp);
  >
  > +		hgc_setenv(hgc);
  
  I prefer passing in (const char**)environ to hgc_setenv().

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8021/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8021

To: spectral, #hg-reviewers
Cc: yuja, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list