D8022: chg: pass copies of some envvars so we can detect py37+ modifications

Yuya Nishihara yuya at tcha.org
Thu Jan 30 09:34:46 EST 2020


>   Getting this implemented "correctly" using daemon_postexec is getting relatively complicated - there's no way to backwards- and forwards-compatibly do this since there's no capabilities mechanism for daemon_postexec. If I blindly do it, it fails when connecting to an older hg saying it doesn't know how to do handle that command.

For the record, chg doesn't need to support old hg versions. We did once
add `--daemon-postexec chdir:/` for example.

>   In execcmdserver, we copy LC_CTYPE to CHGORIG_LC_CTYPE, export that when starting
>   In chgserver.py, when doing the initial startup process, check if CHGORIG_LC_CTYPE is in the environment, and overwrite LC_CTYPE with its value.
>   
>   I'll see how easy that is to implement and send a separate review request once I have it working.

Thanks. I'll review it soon.


More information about the Mercurial-devel mailing list